Re: Uninitialized-variable warnings in nbtinsert.c - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: Uninitialized-variable warnings in nbtinsert.c
Date
Msg-id CAH2-WzkF=VqWh1snCbzBEtj6BiHtHJhQbgn4dtU51=wozYhYkQ@mail.gmail.com
Whole thread Raw
In response to Uninitialized-variable warnings in nbtinsert.c  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Uninitialized-variable warnings in nbtinsert.c  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Sat, Jun 13, 2020 at 9:17 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I scraped the buildfarm's compiler warnings today, as I do from
> time to time, and I noticed that half a dozen animals that normally
> don't report any uninitialized-variable warnings are complaining
> about "curitup" in _bt_doinsert.

(Clearly you meant _bt_check_unique(), not _bt_doinsert().)

> The simplest fix would be to just initialize curitup to NULL in its
> declaration.  But perhaps there's a better way.

Thanks for bringing this to my attention. I'll push a commit that
initializes curitup shortly, targeting both the v13 branch and the
master branch.

-- 
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: jacana vs -Wimplicit-fallthrough
Next
From: Tom Lane
Date:
Subject: Re: Uninitialized-variable warnings in nbtinsert.c