Postgres Pro
Downloads
Home   >   mailing lists

amcheck/verify_heapam doesn't check for interrupts - Mailing list pgsql-hackers

From Peter Geoghegan
Subject amcheck/verify_heapam doesn't check for interrupts
Date
Msg-id CAH2-Wzk-9RtQgb2QiuLv8j2O0j9tSFKPmmch5nWSZhguUxvbrw@mail.gmail.com
Whole thread Raw
Responses Re: amcheck/verify_heapam doesn't check for interrupts
List pgsql-hackers
Tree view 
I just noticed that the new heapam amcheck verification code can take
a very long time to respond to cancellations from pg_amcheck -- I saw
that it took over 2 minutes on a large database on my workstation.

It looks like we neglect to call CHECK_FOR_INTERRUPTS() anywhere
inside verify_heapam.c. Is there any reason for this? Can't we just
put a CHECK_FOR_INTERRUPTS() at the top of the outermost loop, inside
verify_heapam()?

Not sure if pg_amcheck itself is a factor here too -- didn't get that far.

Thanks
-- 
Peter Geoghegan

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: Mark all GUC variable as PGDLLIMPORT
Next
From: Peter Smith
Date:
Subject: Re: row filtering for logical replication