Re: pgsql: Harmonize reorderbuffer parameter names. - Mailing list pgsql-committers

From Peter Geoghegan
Subject Re: pgsql: Harmonize reorderbuffer parameter names.
Date
Msg-id CAH2-Wz=kT3AWORewCA8wB8G3=zghdoVV6QjcPjnTTFxT9mEdjA@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Harmonize reorderbuffer parameter names.  (Peter Geoghegan <pg@bowt.ie>)
List pgsql-committers
On Sun, Sep 18, 2022 at 2:14 PM Peter Geoghegan <pg@bowt.ie> wrote:
> One further caveat here is that I seem to need to set "IgnoreMacros:
> false" to get perfect results for the "inconsistent" check when the C
> preprocessor is involved, as it often is (e.g., with TransactionId
> params).

Actually that explanation is wrong. In any case trial and error has
shown that "IgnoreMacros=false" [1] and "Strict=true" produce the most
useful results.

[1]
https://releases.llvm.org/14.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/readability-inconsistent-declaration-parameter-name.html#cmdoption-arg-IgnoreMacros

-- 
Peter Geoghegan



pgsql-committers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: pgsql: Harmonize reorderbuffer parameter names.
Next
From: John Naylor
Date:
Subject: pgsql: Fix typos referring to PGPROC