Re: pgsql: pg_regress: Don't use absolute paths for the diff - Mailing list pgsql-committers

From Peter Geoghegan
Subject Re: pgsql: pg_regress: Don't use absolute paths for the diff
Date
Msg-id CAH2-Wz=ZaVxsQSiUJYULckMZcRdbAnP61EF=bkTK=KZMc4bBwg@mail.gmail.com
Whole thread Raw
In response to pgsql: pg_regress: Don't use absolute paths for the diff  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: pgsql: pg_regress: Don't use absolute paths for the diff  (Andres Freund <andres@anarazel.de>)
List pgsql-committers
On Thu, Feb 21, 2019 at 10:01 AM Peter Eisentraut <peter@eisentraut.org> wrote:
> pg_regress: Don't use absolute paths for the diff
>
> Don't expand inputfile and outputfile to absolute paths globally, just
> where needed.  In particular, pass them as is to the file name
> arguments of the diff command, so that we don't see the full absolute
> path in the diff header, which makes the diff unnecessarily verbose
> and harder to read.

This broke some of my tooling for quickly reconciling expected and
actual test outputs from my text editor.

I don't think that this was a great idea.

-- 
Peter Geoghegan


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix plan created for inherited UPDATE/DELETE with all tablesexc
Next
From: Michael Paquier
Date:
Subject: pgsql: Add TAP tests for 2PC post-commit callbacks of multixacts atrec