Re: pgsql: Add deduplication to nbtree. - Mailing list pgsql-committers

From Peter Geoghegan
Subject Re: pgsql: Add deduplication to nbtree.
Date
Msg-id CAH2-Wz=Tz_e8e39qTs3Mt78P6XD9s3u7TdOUVrYZg2eTEgfB0w@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Add deduplication to nbtree.  (Peter Geoghegan <pg@bowt.ie>)
Responses Re: pgsql: Add deduplication to nbtree.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On Sun, Mar 1, 2020 at 11:42 AM Peter Geoghegan <pg@bowt.ie> wrote:
> > Do you want to try coding it that way and see what it
> > comes out like?
>
> Sure.

Attached patch shows how this could work. I prefer my original
approach, but I can see the argument for doing it this way.

If we keep my original approach, we should still add a new
"ItemPointerIsValid(&itup->t_tid)" assertion that covers the plain
tupe case in a way that mirrors the current "_bt_posting_valid(itup)"
assert.

-- 
Peter Geoghegan

Attachment

pgsql-committers by date:

Previous
From: Peter Geoghegan
Date:
Subject: pgsql: Remove dead code from _bt_update_posting().
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Add deduplication to nbtree.