Re: Unimpressed with pg_attribute_always_inline - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: Unimpressed with pg_attribute_always_inline
Date
Msg-id CAH2-Wz=CgOTppSNyJnAHNYV5XiuhVs-21eTC0WuaKYCoaPWqLQ@mail.gmail.com
Whole thread Raw
In response to Re: Unimpressed with pg_attribute_always_inline  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Unimpressed with pg_attribute_always_inline
List pgsql-hackers
On Mon, Jan 8, 2018 at 4:12 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> When I complained that always_inline inhibits debuggability, I did NOT
> mean what shows up in perf reports.  I'm talking about whether you can
> break at, or single-step through, a function reliably and whether gdb
> knows where all the variables are.  In my experience, inlining hurts
> both of those things, which is why I'm saying that forcing inlining
> even in non-optimized builds is a bad idea.

Isn't that an argument against inlining in general, rather than
forcing inlining in particular?

-- 
Peter Geoghegan


pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Unimpressed with pg_attribute_always_inline
Next
From: Andres Freund
Date:
Subject: Re: Unimpressed with pg_attribute_always_inline