Re: pgsql: Try to unbreak MSVC builds for pg_waldump - Mailing list pgsql-committers

On Sat, Apr 8, 2023 at 10:53 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I thought we were planning to drop the MSVC build scripts for v16.
> Is that no longer happening?  If they're going to be around for
> awhile, maybe that CI job needs to be resurrected.

It seems as if commit e6b6ea02 had very good reasons to replace the
MSVC build scripts with a meson build; it's really slow, and wastes a
lot of cycles, while testing much less than meson. So I doubt that
we'd want to restore exactly what was in place prior to that commit.

If we can't just drop the MSVC build scripts, perhaps we could add
something akin to the existing CompilerWarnings target. Something
that's purely intended to detect these kinds of oversights. Even that
seems excessive to me, though. I hope that we can just get rid of the
scripts before long.

--
Peter Geoghegan