Re: run pgindent on a regular basis / scripted manner - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: run pgindent on a regular basis / scripted manner
Date
Msg-id CAH2-Wz=+23=O6iioUR_k9-mgUoX2kJPOWW5JdOXmd5dCtvinVg@mail.gmail.com
Whole thread Raw
In response to Re: run pgindent on a regular basis / scripted manner  (Andres Freund <andres@anarazel.de>)
Responses Re: run pgindent on a regular basis / scripted manner
List pgsql-hackers
On Fri, Aug 11, 2023 at 2:25 PM Andres Freund <andres@anarazel.de> wrote:
> > I don't think that it makes sense to invent yet another rule for
> > .git-blame-ignore-revs, though. Will we need another buildfarm member
> > to enforce that rule, too?
>
> We could a test that fails when there's some mis-indented code. That seems
> like it might catch things earlier?

It definitely would. That would go a long way towards addressing my
concerns. But I suspect that that would run into problems that stem
from the fact that the buildfarm is testing something that isn't all
that simple. Don't typedefs need to be downloaded from some other
blessed buildfarm animal?

--
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: AssertLog instead of Assert in some places
Next
From: Marcelo Juchem
Date:
Subject: Re: [PATCH] Support static linking against LLVM