Re: [BUG]Update Toast data failure in logical replication - Mailing list pgsql-hackers

From Kuntal Ghosh
Subject Re: [BUG]Update Toast data failure in logical replication
Date
Msg-id CAGz5QCLND451Rc4iu9LsXLTOUV+z5nWNabOOaDzdBrQqAC+jEw@mail.gmail.com
Whole thread Raw
In response to Re: [BUG]Update Toast data failure in logical replication  (Dilip Kumar <dilipbalaut@gmail.com>)
Responses Re: [BUG]Update Toast data failure in logical replication
List pgsql-hackers
On Wed, Jun 2, 2021 at 3:10 PM Dilip Kumar <dilipbalaut@gmail.com> wrote:
>
> Yes, you are right.  I will change it in the next version, along with
> the test case.
>
+    /*
+     * if the key hasn't changed and we're only logging the key, we're done.
+     * But if tuple has external data then we might have to detoast the key.
+     */
This doesn't really mention why we need to detoast the key even when
the key remains the same. I guess we can add some more details here.

-- 
Thanks & Regards,
Kuntal Ghosh



pgsql-hackers by date:

Previous
From: Jim Mlodgenski
Date:
Subject: Support for CREATE MODULE?
Next
From: Dilip Kumar
Date:
Subject: Re: [BUG]Update Toast data failure in logical replication