Invalid memory access in pg_stat_get_subscription - Mailing list pgsql-hackers

From Kuntal Ghosh
Subject Invalid memory access in pg_stat_get_subscription
Date
Msg-id CAGz5QCJykEDzW6jQK6Yz7Qh_PMtD=95de_7QoocbVR2Qy8hWZA@mail.gmail.com
Whole thread Raw
Responses Re: Invalid memory access in pg_stat_get_subscription
List pgsql-hackers
Hello hackers,

While exploring some code in logical replication worker
implementation, I noticed that we're accessing an invalid memory while
traversing LogicalRepCtx->workers[i].
For the above structure, we're allocating
max_logical_replication_workers times LogicalRepWorker amount of
memory in ApplyLauncherShmemSize. But, in the for loop, we're
accessing the max_logical_replication_workers + 1 location which is
resulting in random crashes.

Please find the patch that fixes the issue. I'm not sure whether we
should add a regression test for the same.

-- 
Thanks & Regards,
Kuntal Ghosh

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: How about a psql backslash command to show GUCs?
Next
From: Tomas Vondra
Date:
Subject: Re: pgcon unconference / impact of block size on performance