Re: Custom reloptions and lock modes - Mailing list pgsql-hackers

From Kuntal Ghosh
Subject Re: Custom reloptions and lock modes
Date
Msg-id CAGz5QCJv4RmRL8Amdx-R1PQ0mb5hzNcaUneEZ_sHcFu_xsfG6A@mail.gmail.com
Whole thread Raw
In response to Re: Custom reloptions and lock modes  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Custom reloptions and lock modes
List pgsql-hackers
On Fri, Sep 20, 2019 at 12:38 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> > One small thing:
> >
> >   add_int_reloption(bl_relopt_kind, buf,
> >    "Number of bits generated for each index column",
> > -  DEFAULT_BLOOM_BITS, 1, MAX_BLOOM_BITS);
> > +  DEFAULT_BLOOM_BITS, 1, MAX_BLOOM_BITS,
> > +  AccessExclusiveLock);
> > Do we need a comment to explain why we're using AccessExclusiveLock in
> > this case?
>
> Because that's the safest default to use here?  That seemed obvious to
> me.
Okay. Sounds good.



-- 
Thanks & Regards,
Kuntal Ghosh
EnterpriseDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Custom reloptions and lock modes
Next
From: Michael Paquier
Date:
Subject: Re: backup manifests