Re: [PATCH] doc: Document that invalid indexes are skipped during ATTACH PARTITION - Mailing list pgsql-hackers

From Mohamed ALi
Subject Re: [PATCH] doc: Document that invalid indexes are skipped during ATTACH PARTITION
Date
Msg-id CAGnOmWpiG7nSRKgKOKPDCfUMaz4YvOt9Uwt2ETiY5qKTOg0Txg@mail.gmail.com
Whole thread
Responses Re: [PATCH] doc: Document that invalid indexes are skipped during ATTACH PARTITION
List pgsql-hackers
Hi Sami,

Thanks for the review. I agree, rewriting the existing sentence reads
much better than appending a separate one.

I've adopted your suggestion in v2, with one addition: a sentence
noting that invalid indexes remain on the partition and
should be dropped manually if no longer needed.
I think this helps make it clear that the user is responsible for
cleaning those up.

The full paragraph now reads:

For each index in the target table, if a valid equivalent
index already exists in the partition, it will be attached
to the target table's index, as if ALTER INDEX ATTACH
PARTITION had been executed; otherwise, a corresponding
one will be created.  Any invalid indexes on the partition remain
unchanged and should be dropped manually if they are no longer
needed.

v2 patch attached.

-- 
Mohamed Ali

Attachment

pgsql-hackers by date:

Previous
From: Japin Li
Date:
Subject: Re: Report oldest xmin source when autovacuum cannot remove tuples
Next
From: Ewan Young
Date:
Subject: Re: Improve errmsg for publication membership