Request a Demo
Home   >   mailing lists

Re: Improve errmsg for publication membership - Mailing list pgsql-hackers

From Ewan Young
Subject Re: Improve errmsg for publication membership
Date
Msg-id CAON2xHP_z++o7NSMsE-gcG1+qhwtiOy-NoJkrw+qzwMRbkZJ2g@mail.gmail.com
Whole thread
Responses Re: Improve errmsg for publication membership
List pgsql-hackers
Tree view 
On Wed, Jun 3, 2026 at 1:10 PM Peter Smith <smithpb2250@gmail.com> wrote:
>
> Here is a patch to reword 2 publication error messages:
>
> BEFORE/AFTER
> "relation \"%s\" is already member of publication \"%s\"",
> "relation \"%s\" is already a member of publication \"%s\"",
>
> BEFORE/AFTER
> "schema \"%s\" is already member of publication \"%s\"",
> "schema \"%s\" is already a member of publication \"%s\"",
>
> ~~~
>
> All other 'member of' error messages in PostgreSQL source are using
> correct grammar ('a member of'), so IMO these should do likewise.
>
> PSA v1.

Thanks. Patch applies cleanly on master, the wording fix matches all other
'member of' messages in the tree, and make check passes (245/245).  LGTM.

Regards,
Ewan

>
> ======
> Kind Regards,
> Peter Smith.
> Fujitsu Australia

pgsql-hackers by date:

Previous
From: Mohamed ALi
Date:
Subject: Re: [PATCH] doc: Document that invalid indexes are skipped during ATTACH PARTITION
Next
From: Ewan Young
Date:
Subject: Re: [PATCH] Clarify that ssl_groups is for any key exchange groups