Re: [PATCH] doc: Document that invalid indexes are skipped during ATTACH PARTITION - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] doc: Document that invalid indexes are skipped during ATTACH PARTITION
Date
Msg-id ah_XViOx39uoL_kf@paquier.xyz
Whole thread
In response to Re: [PATCH] doc: Document that invalid indexes are skipped during ATTACH PARTITION  (Mohamed ALi <moali.pg@gmail.com>)
List pgsql-hackers
On Tue, Jun 02, 2026 at 10:58:23PM -0700, Mohamed ALi wrote:
> The full paragraph now reads:
>
> For each index in the target table, if a valid equivalent
> index already exists in the partition, it will be attached
> to the target table's index, as if ALTER INDEX ATTACH
> PARTITION had been executed; otherwise, a corresponding
> one will be created.  Any invalid indexes on the partition remain
> unchanged and should be dropped manually if they are no longer
> needed.

Hmm.  How about?
For each index in the target table, if a valid equivalent index
already exists in the partition, it will be attached to the target
table's index, as if ALTER INDEX ATTACH PARTITION had been executed;
otherwise, a new corresponding index will be created.  Invalid indexes
on the partition are skipped.

In short, I am not sure that there is a need to mention the drop;
that's up to the user to decide what to do and that's a DROP INDEX
thing, not an ALTER thing.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Fix \crosstabview to honor \pset display_true/display_false
Next
From: jian he
Date:
Subject: CREATE TABLE LIKE INCLUDING PRIVILEGES