Re: [PATCH] Runtime control of CLOBBER_CACHE_ALWAYS - Mailing list pgsql-hackers

From Craig Ringer
Subject Re: [PATCH] Runtime control of CLOBBER_CACHE_ALWAYS
Date
Msg-id CAGRY4nxRH+WAJsie_=RsA4CnqST4mP9rgeERr79Zmz8okh1tbw@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Runtime control of CLOBBER_CACHE_ALWAYS  (Craig Ringer <craig@2ndquadrant.com>)
List pgsql-hackers
On Thu, 3 Dec 2020 at 15:53, Craig Ringer <craig@2ndquadrant.com> wrote:

On Tue, 27 Oct 2020 at 16:34, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
On 2020-09-25 09:40, Craig Ringer wrote:
> While working on extensions I've often wanted to enable cache clobbering
> for a targeted piece of code, without paying the price of running it for
> all backends during postgres startup and any initial setup tasks that
> are required.
>
> So here's a patch that, when CLOBBER_CACHE_ALWAYS or
> CLOBBER_CACHE_RECURSIVE are defined, adds a GUC named
> clobber_cache_depth . It defaults to 1 for CLOBBER_CACHE_ALWAYS or 3 for
> CLOBBER_CACHE_RECURSIVE to match the existing compiled-in behaviour. But
> with this change it's now possible to run Pg with clobber_cache_depth=0
> then set it to 1 only for targeted tests.

I think it would be great if the cache clobber code is always compiled
in (but turned off) when building with assertions.  The would reduce the
number of hoops to jump through to actually use this locally and reduce
the number of surprises from the build farm.


Updated per your comments Peter, see mail immediately up-thread.

pgsql-hackers by date:

Previous
From: "tsunakawa.takay@fujitsu.com"
Date:
Subject: RE: [Patch] Optimize dropping of relation buffers using dlist
Next
From: Michael Paquier
Date:
Subject: Re: Refactor MD5 implementations and switch to EVP for OpenSSL