Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum - Mailing list pgadmin-hackers

From Sarah McAlear
Subject Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum
Date
Msg-id CAGRPzo_ATD7Erwz=5Eay1GDfXnDq4DvEinYvfsSGQbVBmcxrNg@mail.gmail.com
Whole thread Raw
In response to Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Responses Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum
List pgadmin-hackers
Hi Akshay!
 
Some test file names ended with "_sql_template.py" do we need to add that string ? 
we added this suffix after moving the tests up a level to tables/tests to clarify what subject they applied to. we changed the suffix to "_sql.py"

- Files "test_column_acl_sql_template.py" and "test_column_properties_sql_template.py" should be moved from tables->tests to tables->column->tests. As it's related to column.
- Files "test_trigger_get_oid_sql_template.py" and "test_trigger_nodes_sql_template.py" should be moved from tables->tests to tables->triggers->tests. As its related to triggers.
these tests are related to the sql files in tables/templates/column, not tables/column, so moving them into tables/column would be more confusing. 

Following test cases are failing
Thank you, fixed, see new patch. Can you confirm that TestTablesNodeSql doesn't fail in your environment?

Thanks,
George & Sarah

Attachment

pgadmin-hackers by date:

Previous
From: Murtuza Zabuawala
Date:
Subject: Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the of issue in table node
Next
From: Harshal Dhumal
Date:
Subject: Re: [pgadmin-hackers] Re: Server side cursor limitations for ondemand loading of data in query tool [RM2137] [pgAdmin4]