Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query ResultsGrid User Experience - Mailing list pgadmin-hackers

From Sarah McAlear
Subject Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query ResultsGrid User Experience
Date
Msg-id CAGRPzo_25RwoTxLMVpGy1SANNkD4KaCw0YwdWWBJmV1K-dorbQ@mail.gmail.com
Whole thread Raw
In response to Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query ResultsGrid User Experience  (Surinder Kumar <surinder.kumar@enterprisedb.com>)
Responses Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query ResultsGrid User Experience  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Hello,

Here is a new set of patches with the bug fixed. Good catch, Surinder!

Thanks,
Joao & Sarah



On Tue, Jun 6, 2017 at 12:24 AM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Hi

On Tue, Jun 6, 2017 at 12:13 AM, Shruti B Iyer <siyer@pivotal.io> wrote:
Hi Surinder,

On Mon, Jun 5, 2017 at 2:09 PM Robert Eckhardt <reckhardt@pivotal.io> wrote:
On Mon, Jun 5, 2017 at 9:09 AM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Hi Matthew,

Couple of review comments:
1) Clicking on a new added row(after save) results in console error - screenshot attached.
 
We tried to follow the steps you provided to replicate the bug but couldn't replicate the error.  Can you provide further instructions to help us replicate the bug? Perhaps share a screen video if that makes sense.
Is this occurring on the Edit Table view?
​Sorry for wrong steps.​
​No need to add a new row, just double clicking on ​row selection column of last row will throw that error.

Thanks,
Shruti and Matt


Attachment

pgadmin-hackers by date:

Previous
From: Joao Pedro De Almeida Pereira
Date:
Subject: Re: [pgadmin-hackers] [pgAdmin4][Patch]: Load module's JS files onlywhen required
Next
From: George Gelashvili
Date:
Subject: Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React