Re: Why can't we used CAPITAL LETTERS into replication slot_name? - Mailing list pgsql-hackers

From Rushabh Lathia
Subject Re: Why can't we used CAPITAL LETTERS into replication slot_name?
Date
Msg-id CAGPqQf15vQCbff+USVqA_iW+VQ4q7s2DjMctHOhcejCyHSCtHQ@mail.gmail.com
Whole thread Raw
In response to Re: Why can't we used CAPITAL LETTERS into replication slot_name?  (Andres Freund <andres@anarazel.de>)
Responses Re: Why can't we used CAPITAL LETTERS into replication slot_name?  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Thanks Andres.

PFA patch to fix the hint message.

On Fri, Sep 25, 2015 at 5:34 PM, Andres Freund <andres@anarazel.de> wrote:
Hi,

On 2015-09-25 17:32:39 +0530, Rushabh Lathia wrote:
> I am just wondering why pg_create_physical_replication_slot() can't take
> CAPITAL LETTERS into slot_name ?

Windows. And OSX. Specifically case-insensitive filenames.

> If its by design then was should atleast change the hint into
> ReplicationSlotValidateName() which says: "Replication slot names may only
> contain letters, numbers, and the underscore character."

We could add a 'lower case' in there.

Greetings,

Andres Freund



Regards,
Rushabh Lathia
Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Why can't we used CAPITAL LETTERS into replication slot_name?
Next
From: Tomas Vondra
Date:
Subject: Re: DBT-3 with SF=20 got failed