Re: Adding clarification to description of IPC wait events XactGroupUpdate and ProcArrayGroupUpdate - Mailing list pgsql-hackers

From SAMEER KUMAR
Subject Re: Adding clarification to description of IPC wait events XactGroupUpdate and ProcArrayGroupUpdate
Date
Msg-id CAGPeHmi1j9itUBp8iVzD6b1UqaxuV=N2vrOeKfgyka2O=T2EtQ@mail.gmail.com
Whole thread Raw
In response to Adding clarification to description of IPC wait events XactGroupUpdate and ProcArrayGroupUpdate  (SAMEER KUMAR <sameer.kasi200x@gmail.com>)
Responses Re: Adding clarification to description of IPC wait events XactGroupUpdate and ProcArrayGroupUpdate
List pgsql-hackers




On Thu, Aug 15, 2024 at 4:00 AM Nathan Bossart <nathandbossart@gmail.com> wrote:
On Wed, Aug 14, 2024 at 10:38:49PM +0800, SAMEER KUMAR wrote:
> Yes, while reviewing the history of changes, I too noticed the same. The
> documentation of older versions (v12 [1]) still has old descriptions.

After reading the related threads and code, I'm inclined to agree that this
is a mistake, or at least that the current wording is likely to mislead
folks into thinking it has something to do with parallel query.  I noticed
that your patch changed a few things in the description, but IMHO we should
keep the fix focused, i.e., just replace "end of a parallel operation" with
"transaction end."  I've attached a modified version of the patch with this
change.

Thanks for the feedback Nathan.

I think it is important to indicate that the group leader is responsible for clearing the transaction ID/transaction status of other backends (including this one). 

If you suggest that we keep it simple, I don't see any other issues with your patch.
 

--
nathan

pgsql-hackers by date:

Previous
From: "Euler Taveira"
Date:
Subject: Re: Opinion poll: Sending an automated email to a thread when it gets added to the commitfest
Next
From: "Joel Jacobson"
Date:
Subject: Re: [PATCH] Add get_bytes() and set_bytes() functions