1. + target table. However, logical replication in binary format is more + restrictive. See the <literal>binary</literal> option of + <link linkend="sql-createsubscription-binary"><command>CREATE SUBSCRIPTION</command></link> + for details. </para>
Because you've changed the linkend to be the binary option, IMO now the <link> part also needs to be modified. Otherwise, this page has multiple "CREATE SUBSCRIPTION" links which jump to different places, which just seems wrong to me.
Makes sense. I changed it as you suggested.
3. I think there can only be 0 or 1 list element in 'options'.
So, why does the code here use lappend(options,...) instead of just using list_make1(...)?
> Explaining the issue explicitly with a comment seems better to me than the trick of changing order of table creation just for some test cases. > But I'm also ok with removing the use of disable_on_error if that's what you agree on. >
