Postgres Pro
Downloads
Home   >   mailing lists

Re: Allow logical replication to copy tables in binary format - Mailing list pgsql-hackers

From Melih Mutlu
Subject Re: Allow logical replication to copy tables in binary format
Date
Msg-id CAGPVpCSb7gE+9LLSkt7zU_jVo9_qRuv9jOESWWkG9ZauvCgamw@mail.gmail.com
Whole thread Raw
In response to Re: Allow logical replication to copy tables in binary format  (Peter Smith <smithpb2250@gmail.com>)
Responses RE: Allow logical replication to copy tables in binary format
Re: Allow logical replication to copy tables in binary format
Re: Allow logical replication to copy tables in binary format
List pgsql-hackers
Tree view
Hi,

Attached v13.

Peter Smith <smithpb2250@gmail.com>, 14 Mar 2023 Sal, 03:07 tarihinde şunu yazdı:
Here are some review comments for patch v12-0001

Thanks for reviewing. I tried to make explanations in docs better according to your comments.
What do you think?

 Amit Kapila <amit.kapila16@gmail.com>, 14 Mar 2023 Sal, 06:17 tarihinde şunu yazdı:
I think it would better to write the tests for this feature in the
existing test file 014_binary as that would save some time for node
setup/shutdown and also that would be a more appropriate place for
these tests.

I removed 032_binary_copy.pl and added those tests into 014_binary.pl. 
Also added the case with different column order as Peter suggested.

Best,
--
Melih Mutlu
Microsoft
Attachment

pgsql-hackers by date:

Previous
From: Gilles Darold
Date:
Subject: Re: [Proposal] Allow pg_dump to include all child tables with the root table
Next
From: gkokolatos@pm.me
Date:
Subject: Re: Add LZ4 compression in pg_dump