Postgres Pro
Downloads
Home   >   mailing lists

Re: Time delayed LR (WAS Re: logical replication restrictions) - Mailing list pgsql-hackers

From Melih Mutlu
Subject Re: Time delayed LR (WAS Re: logical replication restrictions)
Date
Msg-id CAGPVpCS7GnrTy4dL61Cp2LP1Z=huO4+_MpkTFG=sK5dS4WexHg@mail.gmail.com
Whole thread Raw
In response to RE: Time delayed LR (WAS Re: logical replication restrictions)  ("Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>)
Responses RE: Time delayed LR (WAS Re: logical replication restrictions)
List pgsql-hackers
Tree view
Hi,

I've a question about 032_apply_delay.pl.

+# Test ALTER SUBSCRIPTION. Delay 86460 seconds (1 day 1 minute).
+$node_subscriber->safe_psql('postgres',
+    "ALTER SUBSCRIPTION tap_sub SET (min_apply_delay = 86460000)"
+);
+
+# New row to trigger apply delay.
+$node_publisher->safe_psql('postgres',
+    "INSERT INTO test_tab VALUES (0, 'foobar')");
+

I couldn't quite see how these lines test whether ALTER SUBSCRIPTION successfully worked.
Don't we need to check that min_apply_delay really changed as a result?

But also I see that subscription.sql already tests this ALTER SUBSCRIPTION behaviour.

Best,
--
Melih Mutlu
Microsoft

pgsql-hackers by date:

Previous
From: "houzj.fnst@fujitsu.com"
Date:
Subject: RE: Perform streaming logical transactions by background workers and parallel apply
Next
From: Matthias van de Meent
Date:
Subject: Re: Named Operators