Allow logical replication to copy tables in binary format - Mailing list pgsql-hackers

From Melih Mutlu
Subject Allow logical replication to copy tables in binary format
Date
Msg-id CAGPVpCQvAziCLknEnygY0v1-KBtg+Om-9JHJYZOnNPKFJPompw@mail.gmail.com
Whole thread Raw
Responses Re: Allow logical replication to copy tables in binary format
Re: Allow logical replication to copy tables in binary format
List pgsql-hackers
Hey hackers,

I see that logical replication subscriptions have an option to enable binary [1]. 
When it's enabled, subscription requests publisher to send data in binary format. 
But this is only the case for apply phase. In tablesync, tables are still copied as text.

To copy tables, COPY command is used and that command supports copying in binary. So it seemed to me possible to copy in binary for tablesync too.
I'm not sure if there is a reason to always copy tables in text format. But I couldn't see why not to do it in binary if it's enabled.

You can find the small patch that only enables binary copy attached.  

What do you think about this change? Does it make sense? Am I missing something?


Best,
Melih
Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Generalize ereport_startup_progress infrastructure
Next
From: Jacob Champion
Date:
Subject: Re: [PATCH] Expose port->authn_id to extensions and triggers