Re: Printing LSN made easy - Mailing list pgsql-hackers

From Ashutosh Bapat
Subject Re: Printing LSN made easy
Date
Msg-id CAGEoWWS_OavSm3Yyfh_vHBp0qvjDwbMhcT3=dnVfKr5dA_88Qg@mail.gmail.com
Whole thread Raw
In response to Re: Printing LSN made easy  (Li Japin <japinli@hotmail.com>)
List pgsql-hackers


On Mon, Nov 30, 2020 at 7:38 PM Li Japin <japinli@hotmail.com> wrote:
Hi,

On Nov 30, 2020, at 9:06 PM, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> wrote:

On Fri, Nov 27, 2020 at 9:51 PM Li Japin <japinli@hotmail.com> wrote:

Hi,

Here, we cannot use sizeof(but) to get the buf size, because it is a pointer, so it always
8 bytes on 64-bit or 4 bytes on 32-bit machine.

For an array, the sizeof() returns the size of memory consumed by the
array. See section "Application to arrays" at
https://en.wikipedia.org/wiki/Sizeof.

That’s true! However, in pg_lsn_out_buffer(), it converts to a pointer, not an array. See the following test:


Ah! Thanks for pointing that out. I have fixed this in my repository. However, from Alvaro's reply it looks like the approach is not acceptable, so I am not posting the fixed version here.

--
Best Wishes,
Ashutosh

pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: Re: Two fsync related performance issues?
Next
From: Thomas Munro
Date:
Subject: Github Actions (CI)