Re: Diagnostic comment in LogicalIncreaseXminForSlot - Mailing list pgsql-hackers

From Ashutosh Bapat
Subject Re: Diagnostic comment in LogicalIncreaseXminForSlot
Date
Msg-id CAGEoWWQFJAqhw1a512cHW+kiv8QS1usHeYSvEsZrqw2snB5dVw@mail.gmail.com
Whole thread Raw
In response to Re: Diagnostic comment in LogicalIncreaseXminForSlot  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: Diagnostic comment in LogicalIncreaseXminForSlot  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
Yeah, I agree. Sorry for missing that.

The updated patch looks good to me.

On Mon, Sep 6, 2021 at 3:25 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
On Tue, Aug 17, 2021 at 11:58 AM Ashutosh Bapat
<ashutosh.bapat@enterprisedb.com> wrote:
>
> Hi Amit and Andres,
> Here's updated patch
>

I think we can log the required information immediately after
releasing spinlock, otherwise, the other logs from
LogicalConfirmReceivedLocation() might interleave. I have made that
change and slightly edit the comment and commit message. I am planning
to push this tomorrow unless you or others have any comments.

--
With Regards,
Amit Kapila.


--
--
Best Wishes,
Ashutosh

pgsql-hackers by date:

Previous
From: Dilip Kumar
Date:
Subject: Re: [BUG] Failed Assertion in ReorderBufferChangeMemoryUpdate()
Next
From: Fujii Masao
Date:
Subject: Re: Allow escape in application_name