Re: [PATCH] Handle SK_SEARCHNULL and SK_SEARCHNOTNULL in HeapKeyTest - Mailing list pgsql-hackers

From Jelte Fennema-Nio
Subject Re: [PATCH] Handle SK_SEARCHNULL and SK_SEARCHNOTNULL in HeapKeyTest
Date
Msg-id CAGECzQSuCbJWnozvjHLqZSFkh9cT8V9FUf0+wW0_NcjrJEJA6Q@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Handle SK_SEARCHNULL and SK_SEARCHNOTNULL in HeapKeyTest  (Aleksander Alekseev <aleksander@timescale.com>)
List pgsql-hackers
On Tue, 2 Jul 2024 at 10:15, Aleksander Alekseev
<aleksander@timescale.com> wrote:
> The referred patch was rejected at first because it didn't modify
> nodeSeqScan.c to make use of the change within the core.

I guess we interpret Heikis email differently. I read it as: "If this
improves performance, then let's also start using it in core. If not,
why do extensions need it?" And I think you quite clearly explained
that even if perf is not better, then the usability for extensions
that don't want to use SPI is better.

I don't think Heiki meant his response as not using it in core being a
blocker for the patch. But maybe my interpretation of his response is
incorrect.



pgsql-hackers by date:

Previous
From: shveta malik
Date:
Subject: Re: Conflict Detection and Resolution
Next
From: Dean Rasheed
Date:
Subject: Re: Optimize numeric.c mul_var() using the Karatsuba algorithm