Re: Flushing large data immediately in pqcomm - Mailing list pgsql-hackers

From Jelte Fennema-Nio
Subject Re: Flushing large data immediately in pqcomm
Date
Msg-id CAGECzQRNBaGu8TrUk+oAnTSd4r1-Osb7a8R6w8FJDzBhKTpeyA@mail.gmail.com
Whole thread Raw
In response to Re: Flushing large data immediately in pqcomm  (Andres Freund <andres@anarazel.de>)
Responses Re: Flushing large data immediately in pqcomm
List pgsql-hackers
On Sat, 6 Apr 2024 at 22:21, Andres Freund <andres@anarazel.de> wrote:
> The small regression for small results is still kinda visible, I haven't yet
> tested the patch downthread.

Thanks a lot for the faster test script, I'm also impatient. I still
saw the small regression with David his patch. Here's a v6 where I
think it is now gone. I added inline to internal_put_bytes too. I
think that helped especially because for two calls to
internal_put_bytes len is a constant (1 and 4) that is smaller than
PqSendBufferSize. So for those calls the compiler can now statically
eliminate the new codepath because "len >= PqSendBufferSize" is known
to be false at compile time.

Also I incorporated all of Ranier his comments.

Attachment

pgsql-hackers by date:

Previous
From: Dmitry Koval
Date:
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
Next
From: Thomas Munro
Date:
Subject: Re: Extension Enhancement: Buffer Invalidation in pg_buffercache