Re: [PATCH] Align GSS and TLS error handling in PQconnectPoll() - Mailing list pgsql-hackers

From Jelte Fennema
Subject Re: [PATCH] Align GSS and TLS error handling in PQconnectPoll()
Date
Msg-id CAGECzQR6p6HuMxPVNmovW0n5pAyBjDDz661hR1D9FwsKRuMH=A@mail.gmail.com
Whole thread Raw
In response to [PATCH] Align GSS and TLS error handling in PQconnectPoll()  (Jacob Champion <jchampion@timescale.com>)
Responses Re: [PATCH] Align GSS and TLS error handling in PQconnectPoll()
List pgsql-hackers
Patch looks good to me. Definitely an improvement over the status quo.

Looking at the TLS error handling though I see these two lines:

&& conn->allow_ssl_try    /* redundant? */
&& !conn->wait_ssl_try) /* redundant? */

Are they actually redundant like the comment suggests? If so, we
should probably remove them (in another patch). If not (or if we don't
know), should we have these same checks for GSS?



pgsql-hackers by date:

Previous
From: John Naylor
Date:
Subject: Re: Todo: Teach planner to evaluate multiple windows in the optimal order
Next
From: Daniel Gustafsson
Date:
Subject: Re: Missing default value of createrole_self_grant in document