Re: Add Postgres module info - Mailing list pgsql-hackers

From Yurii Rashkovskii
Subject Re: Add Postgres module info
Date
Msg-id CAG=VW16mY1K1645CbSu41OCfASVRMfQze5h9GbnB3rHqHUw6CQ@mail.gmail.com
Whole thread Raw
In response to Re: Add Postgres module info  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Add Postgres module info
List pgsql-hackers
On Wed, Mar 26, 2025 at 7:45 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> This recent patch is great but causes a small problem. It mixes designated
> and non-designated initializers, specifically in `PG_MODULE_MAGIC_DATA(0)`.

Ugh.  I felt a bit itchy about that, but my compiler wasn't
complaining...

That's because this is valid in C99/C11; it's just not valid in C++. That said, I think it's confusing and error-prone.
 

Can you propose a specific change to clean it up?  I wanted to write
just "PG_MODULE_MAGIC_DATA()", but I'm not sure that's valid C either.

I was thinking about passing `.name = NULL, .version = NULL` instead of `0`—do you have any reservations about this?

Yurii

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Add Postgres module info
Next
From: Tom Lane
Date:
Subject: Re: Use CLOCK_MONOTONIC_COARSE for instr_time when available