Re: [pgAdmin4][RM#3324] - Windows user unable to expand "ExternalTables" navigation item - Mailing list pgadmin-hackers

From Anthony Emengo
Subject Re: [pgAdmin4][RM#3324] - Windows user unable to expand "ExternalTables" navigation item
Date
Msg-id CAG8BBZPusSpR4xjvH-=OEW2RDejW=jgv3JyviyyY6Gb9ee425Q@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4][RM#3324] - Windows user unable to expand "External Tables"navigation item  (Anthony Emengo <aemengo@pivotal.io>)
Responses Re: [pgAdmin4][RM#3324] - Windows user unable to expand "ExternalTables" navigation item  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Forgive me but please consider the following patch instead - as it better adheres to the python style guide.

On Wed, May 2, 2018 at 12:43 PM Anthony Emengo <aemengo@pivotal.io> wrote:

Hi Hackers,

Please find the attached patch to fix the RM #3324 : user cannot load “External Tables” on the navigation pane.

The issue was that ultimately paths were not being cleaned after being munged from the “template” input which would result in template_paths that resembled: path//to//dir.sql. These would work on unix based systems but lead to complication on Windows.

The following patch resolves this issue, and also included a small file refactor to better convey developer intent.

Thanks,
Anthony

Attachment

pgadmin-hackers by date:

Previous
From: Anthony Emengo
Date:
Subject: [pgAdmin4][RM#3324] - Windows user unable to expand "External Tables"navigation item
Next
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin4][Patch] Feature #1447 SSH Tunnel