Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgadmin4][patch] Use ESLinter options instead of using Javascript - Mailing list pgadmin-hackers

From Anthony Emengo
Subject Re: [pgadmin4][patch] Use ESLinter options instead of using Javascript
Date
Msg-id CAG8BBZPCHs1ZBNZdQP+8TyHCXLjHJCd8ngE1Gx_o833MZXM17g@mail.gmail.com
Whole thread Raw
In response to Re: [pgadmin4][patch] Use ESLinter options instead of using Javascript  (Anthony Emengo <aemengo@pivotal.io>)
Responses Re: [pgadmin4][patch] Use ESLinter options instead of using Javascript  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hey all, we'd definitely like some feedback on this patch. Does does it not apply cleanly? Do we need to resend it?

Thanks
Anthony

On Mon, May 14, 2018 at 3:47 PM Anthony Emengo <aemengo@pivotal.io> wrote:
Apologies, here's a redo that should apply cleanly on top of master

Anthony && Joao

On Mon, May 14, 2018 at 3:25 PM Anthony Emengo <aemengo@pivotal.io> wrote:
Hi Hackers,

Attached you can find a patch that changes the way we are running ESLint on the Javascript files. Instead of using Javascript we can use ESLint parameters to archive the same goal.

In the future this will also allow us to use the rest of the cli parameters like (--fix and others...)

Thanks
Anthony && Joao

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Fix a couple of find/replace errors.
Next
From: Khushboo Vashi
Date:
Subject: Re: [pgadmin4][patch] Use ESLinter options instead of using Javascript