Re: frmQuery (multiple result sets support) - patch no.2 - Mailing list pgadmin-hackers

From Ashesh Vashi
Subject Re: frmQuery (multiple result sets support) - patch no.2
Date
Msg-id CAG7mmozUbxSDDh4R4cu2--sQRojvAkiGhkdf6nvBfu3rP6uPGw@mail.gmail.com
Whole thread Raw
In response to frmQuery (multiple result sets support) - patch no.2  (Vladimir Kokovic <vladimir.kokovic@gmail.com>)
List pgadmin-hackers
On Sun, Oct 21, 2012 at 1:45 PM, Vladimir Kokovic <vladimir.kokovic@gmail.com> wrote:
Hi,

My try to add multiple result sets support !
Hi Vladimir Kokovic,

I am not able to apply the patch cleanly on master branch.

patch -p1 <  ~/Downloads/pgadmin3-2.diff
patching file pgadmin/frm/frmQuery.cpp
Hunk #6 succeeded at 2193 (offset 6 lines).
Hunk #7 succeeded at 2288 (offset 6 lines).
Hunk #8 succeeded at 2574 (offset 6 lines).
Hunk #9 succeeded at 2631 (offset 6 lines).
Hunk #10 succeeded at 2649 (offset 6 lines).
Hunk #11 succeeded at 2680 (offset 6 lines).
Hunk #12 succeeded at 2785 (offset 6 lines).
Hunk #13 succeeded at 2840 (offset 6 lines).
Hunk #14 succeeded at 2882 (offset 6 lines).
Hunk #15 succeeded at 2955 (offset 6 lines).
Hunk #16 succeeded at 3034 (offset 6 lines).
patching file pgadmin/include/frm/frmQuery.h
patch unexpectedly ends in middle of line
Hunk #3 succeeded at 310 with fuzz 1.

Can you please take a look at it?

Before - you send the new updated patch, please make sure:
- Use the camel-case instead of underscore in class-name and objects.
- Please do not add new macros unless necessary, and if you find it necessary
  give proper comments for it.
- Write comments for your actions.
- Please test the patch at your end before sending it to the community.

--

Thanks & Regards,
Ashesh Vashi


EnterpriseDB INDIA: Enterprise PostgreSQL Company 

http://www.linkedin.com/in/asheshvashi


Best regards
Vladimir Kokovic
Belgrade, Serbia, 21.October 2012


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


pgadmin-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: pgAdmin III commit: Fix bad wording in create role dialog
Next
From: Ashesh Vashi
Date:
Subject: Re: copy/paste table(s) - patch no.3