Postgres Pro
Downloads
Home   >   mailing lists

Re: backform.pgadmin: fix for showing multiple errors for radio control [pgadmin4] - Mailing list pgadmin-hackers

From Ashesh Vashi
Subject Re: backform.pgadmin: fix for showing multiple errors for radio control [pgadmin4]
Date
Msg-id CAG7mmozD4+pZPm3TXEbti33D8VV6Y2Pv=5Oe+uX=3mzFU3AR4A@mail.gmail.com
Whole thread Raw
In response to backform.pgadmin: fix for showing multiple errors for radio control [pgadmin4]  (Harshal Dhumal <harshal.dhumal@enterprisedb.com>)
List pgadmin-hackers
Tree view


On Thu, Feb 11, 2016 at 6:44 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA patch for backform.pgadmin.js

Issue fixed: Backform was showing same error multiple times (equal to no. of radio buttons in radio group) in dialog.
Approach for this patch is wrong, we should not change the common functionality, and check radio button in it.

That's wrong way to do it.

Though - I've checked-in the fix for it by extending the RadioControl itself.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



See attached screen shot.
-- 
Harshal Dhumal
Software Engineer 





--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: pgAdmin 4 commit: Resolved the issue related showing errors in the radi
Next
From: Ashesh Vashi
Date:
Subject: pgAdmin 4 commit: Adding Numeric control support for Backform.