Postgres Pro
Downloads
Home   >   mailing lists

Re: pgadmin3 segfaults on leaving context menu - Mailing list pgadmin-support

From Ashesh Vashi
Subject Re: pgadmin3 segfaults on leaving context menu
Date
Msg-id CAG7mmoywTSctg6yQ=4OwjSLzMZmBWJ8dOsE5L7uM+FzK0HMesQ@mail.gmail.com
Whole thread Raw
In response to Re: pgadmin3 segfaults on leaving context menu  (Dave Page <dpage@pgadmin.org>)
Responses Re: pgadmin3 segfaults on leaving context menu  (Wander Nauta <info@wandernauta.nl>)
List pgadmin-support
Tree view
Hi Wander Nauta,

As per comment above the mutex lock, we need to hold the lock until, the context menu is getting popped up correctly.
I've modified the code accordingly.

Can you please test the attached patch?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi


On Mon, Apr 20, 2015 at 1:21 PM, Dave Page <dpage@pgadmin.org> wrote:
Ashesh; can you look at this please?

Thanks.

On Sun, Apr 19, 2015 at 3:44 PM, Wander Nauta <info@wandernauta.nl> wrote:
> Hello all,
>
> I did some more digging and it seems frmMain::OnSelRightClick is
> trying to unlock a mutex it doesn't own, which can result in undefined
> behaviour in POSIX.
>
> I've attached a patch that moves the unlock inside the if where the
> mutex is locked. This seems to fix the crash, at least on my end, but
> I couldn't say if it affects thread safety at all.
>
> Again, I hope this helps.
>
> Kind regards,
> Wander Nauta
>
>
> --
> Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-support
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

pgadmin-support by date:

Previous
From: Dave Page
Date:
Subject: Re: pgadmin3 segfaults on leaving context menu
Next
From: Wander Nauta
Date:
Subject: Re: pgadmin3 segfaults on leaving context menu