Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][PATCH] Refactor and change of implementation ofkeyboard_shortcuts function dependencies - Mailing list pgadmin-hackers

From Ashesh Vashi
Subject Re: [pgAdmin4][PATCH] Refactor and change of implementation ofkeyboard_shortcuts function dependencies
Date
Msg-id CAG7mmoxK34qfmmS8a89nmPqSApmiZ_r41rOXt3EPkkNpyDFs0g@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4][PATCH] Refactor and change of implementation ofkeyboard_shortcuts function dependencies  (Sarah McAlear <smcalear@pivotal.io>)
Responses Re: [pgAdmin4][PATCH] Refactor and change of implementation ofkeyboard_shortcuts function dependencies  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
List pgadmin-hackers
Tree view
Murtuza,

On Thu, Aug 3, 2017 at 3:38 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
Hi Hackers!

Attached is a patch that extracts the functions called by the keyboard_shortcuts function extracted earlier from sqlEditor. This includes 
  • executeQuery
  • explainAnalyze
  • explain
  • download
  • commentBlockCode
  • commentLineCode
  • uncommentLineCode

There is still more work to be done, but this is it for now. 

There is also an additional patch that changes the implementation of the commentLineCode, uncommentLineCode, and commentBlockCode functions. The shortcut 
  • for commentLineCode is now  cmd + / (ctrl + / for Windows)
  • for uncommentLineCode cmd + . (ctrl + . for Windows)
  • for comment and uncomment blockCode shift + cmd + / (shift + ctrl + / for Windows)
This is consistent with other IDEs and the way commenting is implemented. 
Please review it, and let us know your comments.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



Thanks!
Hao & Sarah

pgadmin-hackers by date:

Previous
From: pgAdmin 4 Jenkins
Date:
Subject: Build failed in Jenkins: pgadmin4-master-python34 #266
Next
From: Ashesh Vashi
Date:
Subject: Re: [gpAdmin4][patch] query history updates