Postgres Pro
Downloads
Home   >   mailing lists

Re: pgAgent 4.0 patch - Mailing list pgadmin-hackers

From Ashesh Vashi
Subject Re: pgAgent 4.0 patch
Date
Msg-id CAG7mmoxK2A55Sq4ft=fApKkg=8taQTQXgW2eUBsNmvKo0HsF7w@mail.gmail.com
Whole thread Raw
In response to pgAgent 4.0 patch  (Dave Page <dpage@pgadmin.org>)
Responses Re: pgAgent 4.0 patch  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Tree view
On Mon, Jun 4, 2018 at 10:04 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

Can you review the attached please Ashesh?
Hi Dave,

Due to the wrong pattern in '.gitignore', it was ignoring the new file 'sql/pgagent--3.4--4.0.sql'.
We should ignore only the '*.sql' in the root directory.
Something like this.
$ git diff .gitignore
diff --git a/.gitignore b/.gitignore
index 9883354..40fe7a9 100644
--- a/.gitignore
+++ b/.gitignore
@@ -6,7 +6,12 @@ CPackSourceConfig.cmake
 Makefile
 cmake_install.cmake
 install_manifest.txt
-pgagent
+# Ignore 'pgagent' & 'pgagent.control' in root directory only.
+/pgagent
+!/*/pgagent
 pgagent.control
+!/*/pgagent.control
 *.log
-*.sql
+# Ignore '*.sql' files in root directory only.
+/*.sql
+!/*/*.sql

And, I am getting the following warning applying the patch.
$ git apply ~/Downloads/pgagent-4.0-update.diff
/Users/asheshvashi/Downloads/pgagent-4.0-update.diff:320: trailing whitespace.
//
warning: 1 line adds whitespace errors.

Otherwise - it looks good to me.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi 


Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Khushboo Vashi
Date:
Subject: Re: [pgadmin4][Patch]: Test cases for the backup module
Next
From: Aditya Toshniwal
Date:
Subject: Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.