Addition to below, I also observed two more issues,
- It's a bad idea to give md5 hash of current role's password in properties/edit mode, A malicious user can use that hash to crack another role's password.
Ok.
I am not sending the password any more to the client in edit mode.
- When you select a role and click on SQL panel (near to Statistic panel), we encounter exception as below,
File "/home/murtuza/PROJECT/pgadmin4/web/pgadmin/browser/server_groups/servers/roles/__init__.py", line 531, in wrapped return f(self, **kwargs) File "/home/murtuza/PROJECT/pgadmin4/web/pgadmin/browser/server_groups/servers/roles/__init__.py", line 714, in sql data=self.request, AttributeError: 'RoleView' object has no attribute 'request'
Statistics are yet implemented for any node.
It will be taken care as a separate patch.
Regards, Murtuza
On Thursday 14 January 2016 01:48 PM, Murtuza Zabuawala wrote:
Hi Ashesh,
Observed so far,
In pgAdmin4, 1) We are not displaying below items in properties when compare to pgAdmin3 - Account expires - Member of
Added.
2) Seems life one of menu item missing when right click on role - Reassign/ Drop owned
It'll be added as a separate module.
3) Security label is disabled by default, Even though security label is disabled, we get precondition error from server saying.
"errormsg": "Security Label must be passed as an array of JSON object in the following.."
Done.
Causing: - When we add variables in Security tab on existing role, Sql does not gets generated in sql tab. - When we add roles role membership on existing role, Sql does not gets generated in sql tab and it also allow us to enter invalid role which does not exists.