Re: fix for RM1210 [pgadmin4] - Mailing list pgadmin-hackers

From Ashesh Vashi
Subject Re: fix for RM1210 [pgadmin4]
Date
Msg-id CAG7mmowReApeMK8YD7hwHbJWgFqU+Dk7oF312oYOosWHfFONiQ@mail.gmail.com
Whole thread Raw
In response to Re: fix for RM1210 [pgadmin4]  (Harshal Dhumal <harshal.dhumal@enterprisedb.com>)
List pgadmin-hackers
On Fri, Jun 3, 2016 at 1:13 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi Ashesh,

I have used 'ajax_response' utility function (alias to make_response pdadmin utility function) which has mime-type set to "text/json" which is correct I guess in this case.

Also I have check all other node to check if all of them are using correct function while returning sql.
Ok.
Thanks - committed!


--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company





-- 
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jun 3, 2016 at 1:04 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

On Fri, Jun 3, 2016 at 12:59 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:

Hi,

Issue: For column node it was showing wrong sql in sql tab

<html><head></head><body>-- Column: public.test_qmg.a -- ALTER TABLE public.test_qmg DROP COLUMN a; ALTER TABLE public.test_qmg ADD COLUMN a integer;</body></html>

Fix: I have changed response to ajax response while returning SQL for column node.
Hi Harshal,

Can you please introduce a function in pgadmin.utils regarding that, which set the proper mime-type for this purpose, and make sure - we do use that for each and every nodes, for sql and modified_sql methods?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi







-- 
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jun 3, 2016 at 12:52 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Harshal,


Can you please describe the issue, and root cause, and how did you fix it?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi


On Fri, Jun 3, 2016 at 12:48 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA patch for RM1210

-- 
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers






pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: pgAdmin 4 commit: Fixes# 1210 - Send the columns SQL with proper mime t
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Tarball build target and script