Re: Enumize logical replication message actions - Mailing list pgsql-hackers

From Ashutosh Bapat
Subject Re: Enumize logical replication message actions
Date
Msg-id CAG-ACPUir+fq5hhL7FrJ9u10qm3ndJcJWeYihKkq+LYUY3XDng@mail.gmail.com
Whole thread Raw
In response to Re: Enumize logical replication message actions  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: Enumize logical replication message actions
List pgsql-hackers


On Fri, 30 Oct 2020 at 17:37, Amit Kapila <amit.kapila16@gmail.com> wrote:

I don't like the word 'Enumize' in commit message. How about changing
it to something like: (a) Add defines for logical replication protocol
messages, or (b) Associate names with logical replication protocol
messages.

I have used  "Use Enum for top level logical replication message types" in the attached patch. But please free to use (a) if you feel so.
 

+ 2. It's easy to locate the code handling a given type.

In the above instead of 'type', shouldn't it be 'message'.

Used "message type". But please feel free to use "message" if you think that's appropriate.
 

Other than that the patch looks good to me.


Patch with updated commit message and also the list of reviewers  

--
Best Wishes,
Ashutosh
Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Enumize logical replication message actions
Next
From: Laurenz Albe
Date:
Subject: Re: Disable WAL logging to speed up data loading