Re: Compile error on the aarch64 platform: Missing asm/hwcap.h - Mailing list pgsql-hackers

From 高增琦
Subject Re: Compile error on the aarch64 platform: Missing asm/hwcap.h
Date
Msg-id CAFmBtr2Xu_R32RsmDOcTrN+Y6PJFROpYsQEi5ZA8XYNz56HwEw@mail.gmail.com
Whole thread Raw
In response to Re: Compile error on the aarch64 platform: Missing asm/hwcap.h  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Thanks for the quick fix.

There's another one (the last one) in the previous email that needs fixing:

HWCAP_SVE for pg_popcount_aarch64.c

😅

Tom Lane <tgl@sss.pgh.pa.us> 于2025年11月18日周二 04:31写道:
I wrote:
> ... I'm inclined to think
> it's better to do something like

> +#if defined(__linux__) && (defined(__aarch64__) ? !defined(HWCAP_CRC32) : !defined(HWCAP2_CRC32))

> or perhaps that's too unreadable and we should break it out into
> multiple #if's.

I tried it as a nest of #ifdef's and decided that was none too
readable either, so pushed it as above.  Thanks for the report!

                        regards, tom lane


--

pgsql-hackers by date:

Previous
From: "cca5507"
Date:
Subject: Re: minor improvement in snapbuild: use existing interface and removefake code
Next
From: dinesh salve
Date:
Subject: Re: explain plans for foreign servers