Request a Demo
Home   >   mailing lists

Re: minor improvement in snapbuild: use existing interface and removefake code - Mailing list pgsql-hackers

From cca5507
Subject Re: minor improvement in snapbuild: use existing interface and removefake code
Date
Msg-id tencent_1A0E34ECBA42330A6D6A83532865D4F1E609@qq.com
Whole thread Raw
In response to minor improvement in snapbuild: use existing interface and remove fake code  (ocean_li_996 <ocean_li_996@163.com>)
List pgsql-hackers
Tree view
Hi,

Some comments:

1===

Is there a test case can reproduce the assert fail in SnapBuildGetOrBuildSnapshot()?

2===

We skip xact_decode() when SnapBuildCurrentState(builder) < SNAPBUILD_FULL_SNAPSHOT, but it's a bug, so your NO.3 modification might be wrong.

See threads in this for details: https://commitfest.postgresql.org/patch/5029/

--
Regards,
ChangAo Chen

pgsql-hackers by date:

Previous
From: Corey Huinker
Date:
Subject: Re: Extended Statistics set/restore/clear functions.
Next
From: 高增琦
Date:
Subject: Re: Compile error on the aarch64 platform: Missing asm/hwcap.h