Re: [HACKERS] Dropping a partitioned table takes too long - Mailing list pgsql-hackers

From 高增琦
Subject Re: [HACKERS] Dropping a partitioned table takes too long
Date
Msg-id CAFmBtr1N3-SbepJbnGpaYp=jw-FvWMnYY7-bTtRgvjvbyB8YJA@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Dropping a partitioned table takes too long  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [HACKERS] Dropping a partitioned table takes too long  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
It seems that in 'load_relcache_init_file()', we forget to initialize 'rd_pdcxt' of relcache.

2017-04-27 0:33 GMT+08:00 Robert Haas <robertmhaas@gmail.com>:
On Wed, Apr 26, 2017 at 12:22 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> On Tue, Apr 25, 2017 at 10:05 PM, Amit Langote
>> <Langote_Amit_f8@lab.ntt.co.jp> wrote:
>>> Your patch seems to be a much better solution to the problem, thanks.
>
>> Does anyone wish to object to this patch as untimely?
>
>> If not, I'll commit it.
>
> It's certainly not untimely to address such problems.  What I'm wondering
> is if we should commit both patches.  Avoiding an unnecessary heap_open
> is certainly a good thing, but it seems like the memory leak addressed
> by the first patch might still be of concern in other scenarios.

I will defer to you on that.  If you think that patch is a good idea,
please have at it.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--

pgsql-hackers by date:

Previous
From: Konstantin Knizhnik
Date:
Subject: Re: [HACKERS] Cached plans and statement generalization
Next
From: Beena Emerson
Date:
Subject: Re: [HACKERS] Crash when partition column specified twice