Re: Add more regression tests for CREATE OPERATOR - Mailing list pgsql-hackers

From Szymon Guz
Subject Re: Add more regression tests for CREATE OPERATOR
Date
Msg-id CAFjNrYuj5T5KUJ_cTdSsb9241gc7MeKXbRKBSVrSR8f3aKkidQ@mail.gmail.com
Whole thread Raw
In response to Re: Add more regression tests for CREATE OPERATOR  (Josh Berkus <josh@agliodbs.com>)
List pgsql-hackers
On 26 June 2013 21:10, Josh Berkus <josh@agliodbs.com> wrote:

> Is it enough to provide the description in the commitfest app, or is that
> better to send an email and provide link in commitfest?

Better to do it here, on the list.

> This is a patch only with regression tests, is that enough to write
> something like: "This patch applies cleanly on trunk code. All tests pass,
> the test coverage increses as provided."? Or do you expect some more info?

Yes, mainly:

a) does it test what it purports to test?

b) do the tests pass on your machine?


Done, could you confirm that it is OK now?
I've also checked all the patches on the newest trunk.

thanks,
Szymon 

pgsql-hackers by date:

Previous
From: Jeff Janes
Date:
Subject: Re: Hash partitioning.
Next
From: Peter Eisentraut
Date:
Subject: Re: [PATCH] Fix conversion for Decimal arguments in plpython functions