Re: [HACKERS] Potential data loss of 2PC files - Mailing list pgsql-hackers

From Ashutosh Bapat
Subject Re: [HACKERS] Potential data loss of 2PC files
Date
Msg-id CAFjFpRfMYARDmQ4eyBUxUi-NEqWnq+FaS9vKBj=FbPRM5XQwgg@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Potential data loss of 2PC files  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: [HACKERS] Potential data loss of 2PC files  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
On Tue, Jan 3, 2017 at 5:38 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Tue, Jan 3, 2017 at 8:41 PM, Ashutosh Bapat
> <ashutosh.bapat@enterprisedb.com> wrote:
>> Are you talking about
>>     /*
>>      * Now we can mark ourselves as out of the commit critical section: a
>>      * checkpoint starting after this will certainly see the gxact as a
>>      * candidate for fsyncing.
>>      */
>>     MyPgXact->delayChkpt = false;
>>
>> That's while creating the file. I do not see similar code in
>> FinishPreparedTransaction() where the 2PC file is removed.
>
> RecordTransactionCommitPrepared() does the same work for COMMIT PREPARED.

Ok.

I don't have anything more to review in this patch. I will leave that
commitfest entry in "needs review" status for few days in case anyone
else wants to review it. If none is going to review it, we can mark it
as "ready for committer".

-- 
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company



pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: Re: [HACKERS] Logical decoding on standby
Next
From: Ashutosh Bapat
Date:
Subject: Re: [HACKERS] Assignment of valid collation for SET operations onqueries with UNKNOWN types.