Re: Incorrect debug info printed in generate_partition_wise_join_paths - Mailing list pgsql-hackers

From Ashutosh Bapat
Subject Re: Incorrect debug info printed in generate_partition_wise_join_paths
Date
Msg-id CAFjFpRf8Ea+g6RnUO27q4AxJ5PmNxTwKMKx7QYnWWoTG6zK63g@mail.gmail.com
Whole thread Raw
In response to Incorrect debug info printed in generate_partition_wise_join_paths  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
Responses Re: Incorrect debug info printed in generate_partition_wise_join_paths  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
List pgsql-hackers
Yes, that's the correct fix. We should be printing debug information
about the child and not the parent. Sorry for that bug and thanks for
fixing it.

On Fri, Dec 8, 2017 at 3:22 PM, Etsuro Fujita
<fujita.etsuro@lab.ntt.co.jp> wrote:
> generate_partition_wise_join_paths prints debug info, if
> OPTIMIZER_DEBUG, using debug_print_rel at the end of each iteration for
> collecting non-dummy child-joins, but I noticed that we pass to that
> function the parent's RelOptInfo, not such a child-join's RelOptInfo.  I
> don't think it's intentional, so here is a patch for fixing that.
>
> Best regards,
> Etsuro Fujita



-- 
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company


pgsql-hackers by date:

Previous
From: Anthony Bykov
Date:
Subject: Re: Jsonb transform for pl/python
Next
From: Ashutosh Bapat
Date:
Subject: Re: Out of date comment in cached_plan_cost