Re: dropping table in testcase alter_table.sql - Mailing list pgsql-hackers

From Ashutosh Bapat
Subject Re: dropping table in testcase alter_table.sql
Date
Msg-id CAFjFpRecGZhMgpHy8Z_7_T5kYQ-fVhHSaex3-nUztLV4mELOnA@mail.gmail.com
Whole thread Raw
In response to Re: dropping table in testcase alter_table.sql  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: dropping table in testcase alter_table.sql
List pgsql-hackers


On Thu, Jul 7, 2011 at 9:41 PM, Robert Haas <robertmhaas@gmail.com> wrote:
On Thu, Jul 7, 2011 at 3:05 AM, Ashutosh Bapat
<ashutosh.bapat@enterprisedb.com> wrote:
> I noticed that the test alter_table.sql is creating two tables tab1 and tab2
> and it's not dropping it. Any test which follows this test and tries to
> create tables with names tab1 and tab2 will fail (unless it drops those
> tables first, but that may not work, since tab2.y depends upon tab1 in
> alter_table.sql).
>
> PFA patch which drops these two tables from alter_table.sql and
> corresponding OUT change. The regression run clean with this patch.

The regression tests leave lots of objects lying around in the
regression database... why drop these two, as opposed to any of the
others?

I think, tab1 and tab2 are too common names, for anyone to pick up for the tables. Also, the test alter_table.sql is dropping many other tables (even those which have undergone renaming), then why not these two?
 

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Enterprise Postgres Company

pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: [GENERAL] Creating temp tables inside read only transactions
Next
From: Darren Duncan
Date:
Subject: Re: [GENERAL] Creating temp tables inside read only transactions