[HACKERS] Unused member root in foreign_glob_cxt - Mailing list pgsql-hackers

From Ashutosh Bapat
Subject [HACKERS] Unused member root in foreign_glob_cxt
Date
Msg-id CAFjFpReQEGFF81qA==Q8uwJWi9k4kxn5ezssqi-MVpJ3baNB5A@mail.gmail.com
Whole thread Raw
Responses Re: [HACKERS] Unused member root in foreign_glob_cxt  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi,
The member root in foreign_glob_cxt isn't used anywhere by
postgres_fdw code. Without that member the code compiles and
regression passes. The member was added by d0d75c40. I looked at that
commit briefly but did not find any code using it there. So, possibly
it's unused since it was introduced. Should we drop that member?

PFA the patch to remove that member. If we decide to drop that member,
we can drop root argument to is_foreign_expr() and clean up some more
code. I volunteer to do that, if we agree.

-- 
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Dilip Kumar
Date:
Subject: Re: [HACKERS] Parallel bitmap heap scan
Next
From: tushar
Date:
Subject: Re: [HACKERS] Parallel bitmap heap scan