Re: using arrays within structure in ECPG - Mailing list pgsql-hackers

From Ashutosh Bapat
Subject Re: using arrays within structure in ECPG
Date
Msg-id CAFjFpRe6dxuCr3i4BqMuPj-AW8qPNp0sa5nsU4-pOfRNxt3VHg@mail.gmail.com
Whole thread
In response to Re: using arrays within structure in ECPG  (Michael Meskes <meskes@postgresql.org>)
Responses Re: using arrays within structure in ECPG
List pgsql-hackers
So, you are saying that we should try to catch such errors and report during pre-compile time. That's better than silently corrupting the data.


On Tue, Apr 1, 2014 at 10:20 PM, Michael Meskes <meskes@postgresql.org> wrote:
Hi Ashutosh,

> I tried to fix the offset problem. PFA the patch. It does solve the
> problem of setting wrong offset in ECPGdo() call.

Thanks, looks correct to me.

> But then there is problem of interpreting the result from server as an
> array within array of structure. The problem is there is in
> ecpg_get_data(). This function can not understand that the "field" is an
> array of integers (or for that matter array of anything) and store all
> the values in contiguous memory at the given address.

I guess I know where that comes from, without actually looking at the
code, though. Nested arrays are not supported by ecpg and the
precompiler spits out an error message, just check preproc/type.c.
However, in your example you have the struct essantially sandwiched
between the arrays and the (too) simple check in that file doesn't
notice, but because the implementation is nevertheless lacking.

I'm sorry, but this sounds like a missing feature bug.

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL



--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [BUGS] BUG #9518: temporary login failure - "missing pg_hba entry"
Next
From: Andrew Dunstan
Date:
Subject: Re: It seems no Windows buildfarm members are running find_typedefs