Re: [HACKERS] Replacing lfirst() with lfirst_node() appropriately in planner.c - Mailing list pgsql-hackers

From Ashutosh Bapat
Subject Re: [HACKERS] Replacing lfirst() with lfirst_node() appropriately in planner.c
Date
Msg-id CAFjFpRe1RjcNoXhfD6jJw0mHbW4G64WSOu2CXE3O72ifog-Uww@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Replacing lfirst() with lfirst_node() appropriately in planner.c  (Jeevan Chalke <jeevan.chalke@enterprisedb.com>)
Responses Re: [HACKERS] Replacing lfirst() with lfirst_node() appropriately in planner.c
List pgsql-hackers
On Tue, Sep 5, 2017 at 4:02 PM, Jeevan Chalke
<jeevan.chalke@enterprisedb.com> wrote:
> Hi,
>
> lfirst_node() changes are missing for List node type and I was thinking
> about adding those. But it looks like we cannot do so as List can be a
> T_List, T_IntList, or T_OidList. So I am OK with that.

Thanks for investigating the case of T_List.

>
> Apart from this, changes look good to me. Everything works fine.
>
> As we are now doing it for lfirst(), can we also do this for linitial()?
> I did not find any usage for lsecond(), lthird(), lfourth() and llast()
> though.
>
> Attached patch for replacing linitial() with linital_node() appropriately in
> planner.c
>
Ok. The patch looks good to me. It compiles and make check passes.
Here are both the patches rebased on the latest sources.

I am marking this commitfest entry as "ready for committer".

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Rajkumar Raghuwanshi
Date:
Subject: Re: [HACKERS] advanced partition matching algorithm forpartition-wise join
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] Copyright in partition.h and partition.c