Postgres Pro
Downloads
Home   >   mailing lists

Re: postgres_fdw join pushdown (was Re: Custom/Foreign-Join-APIs) - Mailing list pgsql-hackers

From Ashutosh Bapat
Subject Re: postgres_fdw join pushdown (was Re: Custom/Foreign-Join-APIs)
Date
Msg-id CAFjFpRdGLGvSUyc9zCupyMkrR6HpZV9QtAfLWT+dFS52iaxXsg@mail.gmail.com
Whole thread Raw
In response to Re: postgres_fdw join pushdown (was Re: Custom/Foreign-Join-APIs)  (Jeff Janes <jeff.janes@gmail.com>)
Responses Re: postgres_fdw join pushdown (was Re: Custom/Foreign-Join-APIs)
List pgsql-hackers
Tree view
Here's patch to remove this declaration. The Assert next probably prevents the warning for build with asserts. But both those lines are not needed.

On Wed, Feb 10, 2016 at 12:01 PM, Jeff Janes <jeff.janes@gmail.com> wrote:
On Tue, Feb 9, 2016 at 11:16 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Tue, Feb 9, 2016 at 8:39 AM, Ashutosh Bapat
> <ashutosh.bapat@enterprisedb.com> wrote:
>> Thanks Jeevan for your review and comments. PFA the patch which fixes those.
>
> Committed with a couple more small adjustments.

I'm getting a compiler warning which I think is coming from this commit.

postgres_fdw.c: In function 'fetch_more_data':
postgres_fdw.c:2526:17: warning: unused variable 'fsplan' [-Wunused-variable]
    ForeignScan *fsplan = (ForeignScan *) node->ss.ps.plan;

Thanks,

Jeff



--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company
Attachment

pgsql-hackers by date:

Previous
From: Oleg Bartunov
Date:
Subject: Re: old bug in full text parser
Next
From: Magnus Hagander
Date:
Subject: Updated backup APIs for non-exclusive backups